Re: ssh v1 broken in 0.3.4

[Norbert Kiesel <nkiesel@xxxxxxxxxxxxxxx>]

On Wed, 2009-09-23 at 08:46 +0200, Andreas Schneider wrote: 
> On Wednesday 23 September 2009 02:18:38 Norbert Kiesel wrote:
> > Hi,
> if you have some time, it would be nice if you could find the culprit. There 
> is a tool called 'git bisect' which makes it easy to do that.

Spend the morning hunting it down, and found that it actually broke way
back in subversion revision 289 (or 290) when the HAVE_SSH1 was (back
then very partially) replaced with WITH_SSH1.  And 0.3.4 still has 2 #if
HAVE_SSH1 left which are not defined and thus break SSHv1.  I checked in
git and that was fixed in git some time back, but for some reason this
did not make it into 0.3.4 (though AFAICS 0.3.4 was released after that
fix).

I replaced the 2 HAVE_SSH1 with WITH_SSH1 and that made SSHv1 work again
(for me at least, accessing some old Cisco routers).

</nk>