[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libssh patch


Hi Ruben,

First, thank you for your patches. Here are my comments on your patch 0001:
in config.c: please remove the brakets around the case instructions.
They are not needed and mismatch the overall style.
The move/rename of the function is a good idea. Please just fix the
braket issue and this will be merged in the current tree.

Regards,

Aris

RUBEN GARCIA AZUARA a écrit :
> Hi,
> 
>    A Fix patch.
> 
> Regards
> ________________________________________
> De: Andreas Schneider [mail@xxxxxxxxxxxx]
> Enviado el: lunes, 05 de abril de 2010 18:33
> Para: libssh@xxxxxxxxxx
> Asunto: Re: libssh patch
> 
> On Monday 05 April 2010 08:02:57 you wrote:
>> Hello,
> 
> Hi,
> 
>>     I am trying delivering a new patch, but I had never used git.
> 
> http://dev.libssh.org/wiki/HowToSendPatches
> 
> http://book.git-scm.com/ has nice video tutorials.
> 
>>     The first patch include a fix bug to ignore case in HOST parameter.
>>
>>     The second patch add new features: Supports StrictHostKeyChecking and
>> UserKnownHostsFile config parameters.
>>
>>     Sorry if I make some mistakes, and, please, you tell me how could solve
>> them.
> 
> Could you please attach them to the mail?
> 
> Thanks,
> 
> 
>         -- andreas
> 
> 
> 

References:
libssh patchRuben Garcia Azuara <rubenga@xxxxxx>
Re: libssh patchAndreas Schneider <mail@xxxxxxxxxxxx>
RE: libssh patchRUBEN GARCIA AZUARA <rubenga@xxxxxx>
Archive administrator: postmaster@lists.cynapses.org