[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: freebsd6 "port"


Oh ok. I don't like that solution because I think it simply "hides" the problem (in fact cbc_encrypt was being re#define'd by openssl). Could you try the last master commit ? that one fixes the cbc_encrypt problem (without the dereference thing) and the samplesshd miscompile (lack of argp.h on freebsd).

Please let me know if it doesn't compile on 6.4. I managed to make it compile fine on 6.0 with these changes. Actually it's know not to compile on 8.0-beta because of linker options.

Thanks,

Aris

Vic Lee wrote:
Hi Aris,

I have freebsd 6.4 in my virtualbox to actually try it. After the
dereference change, the crypt.c file did compile without error or
warning. However there are some error when compiling samplesshd, haven't
look at this yet.

Thanks,

Vic

On Wed, 2009-11-04 at 10:34 +0100, Aris Adamantiadis wrote:
Hello,

I got the problem. Under freebsd it is needed to link with -fstack-protector if one source file was compiled with it.

But I tried your patch, it didn't change anything. There was no warning with it either, are you sure it's needed ?

Andreas, could you have a look in cmake ? I couldn't find which command to use to add a link parameter if WITH_STACK_PROTECTOR is set.

Btw I am amazed to see that recent versions of libssh are in the freebsd ports. That's a good thing :)

Thanks for the report,

Aris

Vic Lee wrote:
Hi Aris,

Use the dereference way to call function pointers should fix it.

#ifdef HAVE_LIBGCRYPT
  (*(crypto->cbc_encrypt))(crypto, data, out, len);
#elif defined HAVE_LIBCRYPTO
  (*(crypto->cbc_encrypt))(crypto, data, out, len,
      session->current_crypto->encryptIV);
#endif

Vic

On Tue, 2009-11-03 at 20:48 +0100, Aris Adamantiadis wrote:
Alexander,

This looks more like a linking problem with the latest stack protector in freebsd. I don't know how to deal with that ...

Thanks for the feedback.

Aris

Alexander Logvinov a écrit :
Hello!

Hm, there is a new error with samples build:
http://tb.logvinov.com/errors/8-CURRENT-dev-i386/libssh-0.3.91.log

Best regards,
Alexander









Follow-Ups:
Re: freebsd6 "port"Vic Lee <llyzs@xxxxxxx>
References:
Re: freebsd6 "port"Aris Adamantiadis <aris@xxxxxxxxxxxx>
Re: freebsd6 "port"Vic Lee <llyzs@xxxxxxx>
Re: freebsd6 "port"Aris Adamantiadis <aris@xxxxxxxxxxxx>
Re: freebsd6 "port"Vic Lee <llyzs@xxxxxxx>
Archive administrator: postmaster@lists.cynapses.org