Re: [PATCH] don't use regexp in commit.c

[Aris Adamantiadis <aris@xxxxxxxxxxxx>]

Le 12/02/11 13:15, Bernhard R. Link a écrit :
> * Aris Adamantiadis <aris@xxxxxxxxxxxx> [110212 12:32]:
>> Thanks for you feedback. I have a few questions about your patch ; You
>> enumerate a good list of bugs,but why remove the broken code when you
>> can fix it ?
> 
> Well, the functionality can be implemented in 16 lines of code and is
> most likely even faster than goin with a regexp. So why use a regexp
> with all those problems involved if the functionality can be implemented
> natively reducing the total number of lines needed?
Hi Bernhard,

We discussed it and decided to include your patch. Your code makes
sense and I tested it. Please look how Andreas put it on the git.

Thanks,

Aris