[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] Add ssh_get_poll_flags()


On Wednesday 06 November 2013 17:36:49 Colin Walters wrote:
> For integration with an external mainloop, we need to know how to
> replicate libssh's internal poll() calls.  We originally through
> ssh_get_status() was that API, but it's not really - those flags only
> get updated from the *result* of a poll(), where what we really need
> is to know how libssh would *start* a poll().
> ---
>  include/libssh/libssh.h |  1 +
>  include/libssh/socket.h |  1 +
>  src/session.c           | 19 +++++++++++++++++++
>  src/socket.c            | 11 +++++++++++
>  4 files changed, 32 insertions(+)

I've added it. Could you please look into extending it and check for data 
exception and if it is closed. Maybe we need more cleanup and use socket-
>state instead of setting state->data_except.

Aris, could you please comment on the cleanup?

-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx


Follow-Ups:
Re: [PATCH 2/3] Add ssh_get_poll_flags()Colin Walters <walters@xxxxxxxxxx>
References:
[PATCH 2/3] Add ssh_get_poll_flags()Colin Walters <walters@xxxxxxxxxx>
Archive administrator: postmaster@lists.cynapses.org