Re: Microsoft visual C++ compilation problems

[Andreas Schneider <asn@xxxxxxxxxxxxxx>]

On Friday, 25 November 2016 02:20:58 CET Jeremy Cross wrote:
> Mark,
> 
> 
> I provided a patch for this Windows link issue earlier, but it has not been
> accepted yet.

Tilo found that too, I just forgot to cherry-pick for 0.7

https://git.libssh.org/projects/libssh.git/commit/?
h=v0-7&id=9d7f873fd39d867aab9a3f59e999e149fd99f34e

> 
> Here it is again for you:
> 
> 
>  src/session.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/session.c b/src/session.c
> index c29af1e..f6d926a 100644
> --- a/src/session.c
> +++ b/src/session.c
> @@ -270,7 +270,9 @@ void ssh_free(ssh_session session) {
>        ssh_list_free(session->opts.identity);
>    }
> 
> +#ifndef _WIN32
>    ssh_agent_state_free (session->agent_state);
> +#endif
>    session->agent_state = NULL;
> 
>    SAFE_FREE(session->auth_auto_state);
> --
> 2.9.0.windows.1
> 
> 
> Jeremy Cross
> Lead Software Engineer
> 
> +1.601.607.8248 O
> +1.866.522.8694 F
> 
> BOMGAR | Connect Fearlessly<http://www.bomgar.com>
> 
> 
> 
> ________________________________
> From: Mark Ramsden <Mark.Ramsden@xxxxxxxxx>
> Sent: Thursday, November 24, 2016 4:47:09 AM
> To: libssh@xxxxxxxxxx
> Subject: Re: Microsoft visual C++ compilation problems
> 
> Made a mistake with the openssl was v 1.10 not 1.0.1 so grabbed a copy of
> that from git and still cannot get it to compile with VS 2009 with the v0-7
> build getting a link error
> 
> error LNK2019: unresolved external symbol _ssh_agent_state_free referenced
> in function _ssh_free
> 
> I like to think I'm relatively intelligent but this is getting beyond me
> now, trying to put together a proof of concept but think I may have failed
> at first hurdle :(
> 
> 
> On 24/11/2016, 12:42, "Andreas Schneider" <asn@xxxxxxxxxxxxxx> wrote:
> 
>     On Wednesday, 23 November 2016 17:13:39 CET Mark Ramsden wrote:
>     > Aris,
>     > 
>     > Thanks for quick response. The first as you say should be easily
>     > fixable.
>     > 
>     > The second I have pulled from Master and yeah it seems to be the C99
>     > thing.
>     > I would use V0-7 branch but this simply does not play nice with
>     > openssl
>     > 1.0.1. I could I guess try openssl 0.9 but that is now unsupported.
> 
>     I've recently fixed all issues with VS2015 in the v0-7 and master.
> 
> 
>     It compiles just fine for me.
> 
>     --
>     Andreas Schneider                   GPG-ID: CC014E3D
>     www.cryptomilk.org<http://www.cryptomilk.org>               
> asn@xxxxxxxxxxxxxx
> 
> 
> 
> [ESP Leisure]
> [website]<http://www.e-s-p.com/> [facebook]
> <http://www.facebook.com/ESPLeisure>  [twitter]
> <http://twitter.com/ESPLeisure>  [LinkedIN]
> <http://www.linkedin.com/company/2284332> Mark Ramsden
> Systems Analyst
> 
> ESP Leisure Ltd
> 
> Europa House, Kimpton Link Business Park, Kimpton Road, Sutton, Surrey SM3
> 9QP +44 (0)20 8251 5100
> 
> [http://www.e-s-p.com/email_images/centerparcs_tiny.png]
> Winner of the Center Parcs Service and Product Innovation Award 2014
> This message may contain information that is not intended for you. If you
> are not the addressee or if this message was sent to you in error, you are
> requested to inform the sender and delete the message. ESP Leisure,
> Registered in England (reg no 2550976) Registered office: Europa House,
> Kimpton Link Business Park, Kimpton Road, Sutton, Surrey SM3 9QP


-- 
Andreas Schneider                   GPG-ID: CC014E3D
www.cryptomilk.org                asn@xxxxxxxxxxxxxx